Skip to content

OPRUN-4202: Fix issue to sync faced due replace forcing old dependency #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OPRUN-4202: Fix issue to sync faced due replace forcing old dependency #1125

wants to merge 1 commit into from
+9,525 −8,050

Conversation

camilamacedo86
Copy link
Contributor

Description

When we tried to sync the build was failing due to:
grpc.SupportPackageIsVersion9

which is generated by protoc-gen-go-grpc v1.5.1 for code that requires gRPC-Go ≥ v1.64.0.

However, the go.mod currently includes:
replace google.golang.org/grpc => google.golang.org/grpc v1.63.2

This pins the project to an older gRPC version that is incompatible with the generated code.

Fix

Removed the replace directive for google.golang.org/grpc in go.mod.
The replacement was originally added due to limitations with Go 1.23, but we are now using Go 1.24.4, so it is no longer needed. See: operator-framework/operator-lifecycle-manager#3284
This change aligns the project with the upstream OLM (v0) behavior.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 15, 2025 •
edited by openshift-ci bot
Loading

@camilamacedo86: This pull request references OPRUN-4202 which is a valid jira issue.

In response to this:

Description

When we tried to sync the build was failing due to:
grpc.SupportPackageIsVersion9

which is generated by protoc-gen-go-grpc v1.5.1 for code that requires gRPC-Go ≥ v1.64.0.

However, the go.mod currently includes:
replace google.golang.org/grpc => google.golang.org/grpc v1.63.2

This pins the project to an older gRPC version that is incompatible with the generated code.

Fix

Removed the replace directive for google.golang.org/grpc in go.mod.
The replacement was originally added due to limitations with Go 1.23, but we are now using Go 1.24.4, so it is no longer needed. See: operator-framework/operator-lifecycle-manager#3284
This change aligns the project with the upstream OLM (v0) behavior.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from anik120 and oceanc80 October 15, 2025 14:24
@bandrade
Copy link
Contributor

/label qe-approved
/verified by @bandrade

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 15, 2025 •
edited by openshift-ci bot
Loading

@camilamacedo86: This pull request references OPRUN-4202 which is a valid jira issue.

In response to this:

Description

When we tried to sync the build was failing due to:
grpc.SupportPackageIsVersion9

which is generated by protoc-gen-go-grpc v1.5.1 for code that requires gRPC-Go ≥ v1.64.0.

However, the go.mod currently includes:
replace google.golang.org/grpc => google.golang.org/grpc v1.63.2

This pins the project to an older gRPC version that is incompatible with the generated code.

Fix

Removed the replace directive for google.golang.org/grpc in go.mod.
The replacement was originally added due to limitations with Go 1.23, but we are now using Go 1.24.4, so it is no longer needed. See: operator-framework/operator-lifecycle-manager#3284
This change aligns the project with the upstream OLM (v0) behavior.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 15, 2025
@openshift-ci-robot
Copy link

@bandrade: This PR has been marked as verified by @bandrade.

In response to this:

/label qe-approved
/verified by @bandrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@grokspawn
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2025
@camilamacedo86
Copy link
Contributor Author

/test e2e-gcp-olm

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bdc0d75 and 2 for PR HEAD 985b589 in total

@camilamacedo86
Copy link
Contributor Author

/test e2e-gcp-olm

@camilamacedo86
Copy link
Contributor Author

/retest-required

@camilamacedo86
Copy link
Contributor Author

/test e2e-gcp-olm

3 similar comments
@camilamacedo86
Copy link
Contributor Author

/test e2e-gcp-olm

@camilamacedo86
Copy link
Contributor Author

/test e2e-gcp-olm

@camilamacedo86
Copy link
Contributor Author

/test e2e-gcp-olm

@tmshort
Copy link
Contributor

tmshort commented Oct 20, 2025

/retest-required

@anik120
Copy link
Contributor

anik120 commented Oct 20, 2025

/test e2e-gcp-olm

@jianzhangbjz
Copy link
Contributor

/retest-required

@camilamacedo86
Copy link
Contributor Author

/test e2e-gcp-olm

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a0b88f9 and 1 for PR HEAD 985b589 in total

@camilamacedo86
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 22, 2025

@camilamacedo86: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-olm 985b589 link true /test e2e-gcp-olm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@camilamacedo86 camilamacedo86 mentioned this pull request Oct 23, 2025
Open
@camilamacedo86
Copy link
Contributor Author

/test ci/prow/verify-deps

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2025

@camilamacedo86: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws-olmv0-ext

/test e2e-gcp-console-olm

/test e2e-gcp-olm

/test e2e-gcp-ovn

/test e2e-upgrade

/test images

/test okd-scos-images

/test periodics-images

/test tests-extension

/test unit-api

/test unit-olm

/test unit-psm

/test unit-registry

/test verify

/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-gcp-olm-flaky

/test okd-scos-e2e-aws-ovn

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-operator-framework-olm-main-e2e-aws-olmv0-ext

pull-ci-openshift-operator-framework-olm-main-e2e-gcp-console-olm

pull-ci-openshift-operator-framework-olm-main-e2e-gcp-olm

pull-ci-openshift-operator-framework-olm-main-e2e-gcp-ovn

pull-ci-openshift-operator-framework-olm-main-e2e-upgrade

pull-ci-openshift-operator-framework-olm-main-images

pull-ci-openshift-operator-framework-olm-main-okd-scos-e2e-aws-ovn

pull-ci-openshift-operator-framework-olm-main-okd-scos-images

pull-ci-openshift-operator-framework-olm-main-periodics-images

pull-ci-openshift-operator-framework-olm-main-unit-api

pull-ci-openshift-operator-framework-olm-main-unit-olm

pull-ci-openshift-operator-framework-olm-main-unit-psm

pull-ci-openshift-operator-framework-olm-main-unit-registry

pull-ci-openshift-operator-framework-olm-main-verify

pull-ci-openshift-operator-framework-olm-main-verify-deps

In response to this:

/test ci/prow/verify-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@camilamacedo86 camilamacedo86 mentioned this pull request Oct 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anik120 anik120 Awaiting requested review from anik120

@oceanc80 oceanc80 Awaiting requested review from oceanc80

Assignees

@grokspawn grokspawn

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@camilamacedo86 @openshift-ci-robot @bandrade @grokspawn @tmshort @anik120 @jianzhangbjz